Review Request 113649: fix rpath handling
Alexander Neundorf
neundorf at kde.org
Tue Nov 5 22:01:23 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113649/#review43125
-----------------------------------------------------------
Ship it!
Looks good.
- Alexander Neundorf
On Nov. 5, 2013, 8:31 p.m., Rex Dieter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113649/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2013, 8:31 p.m.)
>
>
> Review request for Build System and Phonon.
>
>
> Repository: phonon
>
>
> Description
> -------
>
> Prior to this patch, the cmake code queries/uses ${LIB_INSTALL_DIR} which is a relative path, so an unconditional (relative) rpath gets added.
>
>
> Diffs
> -----
>
> cmake/FindPhononInternal.cmake b48bfaf
>
> Diff: http://git.reviewboard.kde.org/r/113649/diff/
>
>
> Testing
> -------
>
> build/install phonon-4.7.0 to system path on fedora 20 without rpath.
>
>
> Thanks,
>
> Rex Dieter
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20131105/b3c65f96/attachment-0001.html>
More information about the Kde-buildsystem
mailing list