Review Request 113649: fix rpath handling
Rex Dieter
rdieter at gmail.com
Tue Nov 5 20:31:18 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113649/
-----------------------------------------------------------
(Updated Nov. 5, 2013, 8:31 p.m.)
Review request for Build System and Phonon.
Changes
-------
Update to test if ${LIB_INSTALL_DIR} is absolute, and if not, use ${CMAKE_INSTALL_PREFIX}/${LIB_INSTALL_DIR}
Repository: phonon
Description
-------
Prior to this patch, the cmake code queries/uses ${LIB_INSTALL_DIR} which is a relative path, so an unconditional (relative) rpath gets added.
Diffs (updated)
-----
cmake/FindPhononInternal.cmake b48bfaf
Diff: http://git.reviewboard.kde.org/r/113649/diff/
Testing
-------
build/install phonon-4.7.0 to system path on fedora 20 without rpath.
Thanks,
Rex Dieter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20131105/11dda65e/attachment.html>
More information about the Kde-buildsystem
mailing list