Review Request 109404: Give more precedence to qmake executable names that specify the version

[Andrea Scarpino]

> On March 11, 2013, 6:19 a.m., Andrea Scarpino wrote:
> > "I was quite clear: "qmake" must point by default to Qt 4 if Qt 4 present."
> > While qtchooser sounds like a great solution to handle this, it only adds more confusion from a packager view: we cannot have N differents configurations for qt when the users install our packages: qmake points to qt5, no matter which configuration the user did setup for qtchooser.
> > Also, every binary points to the latest version in Arch (e.g. python points to python3 not python2)
> > 
> > However all this discussion isn't related to Arch itself: I think that binaries with specific version takes precedence, don't they?
> 
> Stephen Kelly wrote:
>     No, you also need to account for self-built Qt, which will also result in a binary called 'qmake'.
>     
>     http://thread.gmane.org/gmane.comp.kde.devel.general/65619/focus=65623
> 
> Andrea Scarpino wrote:
>     I don't want to remove the 'qmake' word from the FindQt4.cmake file, but ATM that file looks for:
>     qmake qmake4 qmake-qt4 (and so on) in this order.
>     Why not using this one instead? qmake4 qmake-qt4 qmake...
> 
> Stephen Kelly wrote:
>     Did you follow the link I sent to the thread on the cmake list?
> 
> Andrea Scarpino wrote:
>     No, I missed the reply in the second link in the thread you linked.
>     Ok, I see your point now.
>     
>     I'll think about it.
> 
> Thiago Macieira wrote:
>     It's very simple: if you're going to make an unsupported installation, KDE should feel quite comfortable by not supporting your distribution.
>     
>     CMake can find Qt 5 without qmake, that's why it's recommended that "qmake" point to Qt 4's qmake. For users running qmake manually, the Qt documentation should explain how to run "qmake -qt5" (yes, with the space).
>     
>     Anyway, why is this an issue at all? Why doesn't FindQt4.cmake discard the Qt 5 qmake if the version number is wrong? Shouldn't it try again with a new executable name?

The patch reported here[1] should fix this issue without the need of changing any order. This should work on every distro with any qt setup.

[1] http://public.kitware.com/Bug/view.php?id=13985


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109404/#review28931
-----------------------------------------------------------


On March 11, 2013, 3:29 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109404/
> -----------------------------------------------------------
> 
> (Updated March 11, 2013, 3:29 a.m.)
> 
> 
> Review request for Build System, kdelibs, David Faure, Alexander Neundorf, and Andrea Scarpino.
> 
> 
> Description
> -------
> 
> Recently ArchLinux decided to ship Qt5 and they did so by making qmake point to qmake-qt5 and adding qmake-qt4.
> 
> With this patch, we look first for the executables that specify the version number and then the more generic ones.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindQt4.cmake 6db944f 
> 
> Diff: http://git.reviewboard.kde.org/r/109404/diff/
> 
> 
> Testing
> -------
> 
> cmake_minimum_required(VERSION 2.8)
> 
> find_package(KDE4)
> 
> -----
> 
> Configuring such a project returns the correct versions.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20130311/41c9c8af/attachment.html>