<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109404/">http://git.reviewboard.kde.org/r/109404/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 11th, 2013, 6:19 a.m. CET, <b>Andrea Scarpino</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"I was quite clear: "qmake" must point by default to Qt 4 if Qt 4 present."
While qtchooser sounds like a great solution to handle this, it only adds more confusion from a packager view: we cannot have N differents configurations for qt when the users install our packages: qmake points to qt5, no matter which configuration the user did setup for qtchooser.
Also, every binary points to the latest version in Arch (e.g. python points to python3 not python2)
However all this discussion isn't related to Arch itself: I think that binaries with specific version takes precedence, don't they?</pre>
</blockquote>
<p>On March 11th, 2013, 9:22 a.m. CET, <b>Stephen Kelly</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, you also need to account for self-built Qt, which will also result in a binary called 'qmake'.
http://thread.gmane.org/gmane.comp.kde.devel.general/65619/focus=65623</pre>
</blockquote>
<p>On March 11th, 2013, 9:25 a.m. CET, <b>Andrea Scarpino</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't want to remove the 'qmake' word from the FindQt4.cmake file, but ATM that file looks for:
qmake qmake4 qmake-qt4 (and so on) in this order.
Why not using this one instead? qmake4 qmake-qt4 qmake...</pre>
</blockquote>
<p>On March 11th, 2013, 10:02 a.m. CET, <b>Stephen Kelly</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Did you follow the link I sent to the thread on the cmake list?</pre>
</blockquote>
<p>On March 11th, 2013, 11:03 a.m. CET, <b>Andrea Scarpino</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, I missed the reply in the second link in the thread you linked.
Ok, I see your point now.
I'll think about it.</pre>
</blockquote>
<p>On March 11th, 2013, 4:52 p.m. CET, <b>Thiago Macieira</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's very simple: if you're going to make an unsupported installation, KDE should feel quite comfortable by not supporting your distribution.
CMake can find Qt 5 without qmake, that's why it's recommended that "qmake" point to Qt 4's qmake. For users running qmake manually, the Qt documentation should explain how to run "qmake -qt5" (yes, with the space).
Anyway, why is this an issue at all? Why doesn't FindQt4.cmake discard the Qt 5 qmake if the version number is wrong? Shouldn't it try again with a new executable name?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch reported here[1] should fix this issue without the need of changing any order. This should work on every distro with any qt setup.
[1] http://public.kitware.com/Bug/view.php?id=13985</pre>
<br />
<p>- Andrea</p>
<br />
<p>On March 11th, 2013, 3:29 a.m. CET, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Build System, kdelibs, David Faure, Alexander Neundorf, and Andrea Scarpino.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated March 11, 2013, 3:29 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Recently ArchLinux decided to ship Qt5 and they did so by making qmake point to qmake-qt5 and adding qmake-qt4.
With this patch, we look first for the executables that specify the version number and then the more generic ones.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">cmake_minimum_required(VERSION 2.8)
find_package(KDE4)
-----
Configuring such a project returns the correct versions.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindQt4.cmake <span style="color: grey">(6db944f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109404/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>