Testing file offset bits?

[Stephen Kelly]

Alexander Neundorf wrote:

> On Saturday 16 February 2013, Stephen Kelly wrote:
>> Hi Alex,
>> 
>>     -some compiler flags tweaking
>> 
>>     -reenable the test for visibility in Qt
>>     -reenable the test for FILE_OFFSET_BITS=64 (... there may be maybe
>>     some
>> embedded systems where this is not the case ?)
>> 
>> 
>> Do you have any reason to think this is needed? The maybe is pretty
>> strong in this sentence :).
> 
> First, there was probably a reason why this check was added, so just to be
> sure I enabled it again (it has always been enabled in
> FindKDE4Internal.cmake), it was only disabled in e-c-m.

I don't think adding code we don't understand to ecm is a good idea :). 
People have added things mistakenly, and people have added things for 
platforms where Qt 5 does not work.

Let's not try to 'maintain' things we do not understand. 

Let's simplify and remove instead. In many cases, the correct place to fix 
things is in cmake. One of the whole motivations behind KDE Frameworks is to 
simplify or code, to rely on upstreams(primarily Qt and CMake), and to fix 
upstreams where necessary - not workaround them.

> 
> And, since kf5 libs may be used now independent from the rest of KDE, it
> may be possible that some small library may be used on some weird
> platform, where things are different.
> So better test for it to make sure.

We should let the people using such platforms do that for themselves. They 
have to anyway if they use anything that is not 'kde'.

Thanks,

Steve.