[PATCH 0/3] FindKDE4Internal.cmake compiler code cleanups

[Raphael Kubo da Costa]

Hi there,

I've sent the following patches via git-send-email instead of ReviewBoard to
properly represent the dependencies between each patch (it'd be harder to group
the 3 patches in a single "patchset" using RB).

Patch 1 is the only one which contains an actual bug fix -- for some reason,
many years ago Dirk committed a change which only enabled additional GCC flags
on Linux, which broke things for me when trying to build and review picmi (it
passes -pedantic, and -Wno-long-long is specified in these compiler flags which
are passed only on Linux).

The other patches contain some readability enhancements and remove some dead
code, and are not really essential.

I have tried to change as little as possible, with backward compatibility in
mind, so please let me know if you spot some weird changes.

These changes can also be applied to extra-cmake-modules'
KDECompilerSettings.cmake, and I intend to do that once I get them reviewed and
appplied to KDE/4.9.