kdelibs/kdecore/cmakelists KDE4_ENABLE_EXCEPTIONS cmake failure (4.8, 4.9)

[Michael Pyne]

On Sunday, July 15, 2012 12:50:12 Shaun Reich wrote:
> line 393 of kdecore/cmakelists results in:
> 
> CMake Error at kdecore/CMakeLists.txt:393 (set_source_files_properties):
>   set_source_files_properties called with incorrect number of arguments.
> 
> the line is:
> 
>         set_source_files_properties(util/kshareddatacache.cpp
>             PROPERTIES COMPILE_FLAGS ${KDE4_ENABLE_EXCEPTIONS})
> 
> as suggested by mjansen, applying quotes around the variable fixes it.
> is there a better solution, or is this fine to commit? (cmake errors
> out without this change).

>From a buildsystem perspective it's fine.

If you're asking for permission you'd probably want the release-team mailing 
list instead (but I'll go ahead and be so presumptuous as to say to commit and 
CC: release-team)

Regards,
 - Michael Pyne
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20120715/62814caf/attachment.sig>