[PATCH] FindXine: Make version detection work with xine >= 1.2.0.

Alexander Neundorf neundorf at kde.org
Sat Jan 28 16:47:11 UTC 2012


On Thursday 26 January 2012, Michael Jansen wrote:
> On Thursday, January 26, 2012 09:44:41 PM you wrote:
> > On Thursday 26 January 2012, Michael Jansen wrote:
...
> > > Why? Interested in  breaking cross compiles?
> > 
> > I'd appreciate a somewhat more constructive tone.
> 
> And i personally appreciate people that don't get offended so easily.
> 
> But in any case sorry if that offended you.
> 
> > > I see not other point in doing it.
> > 
> > In case you read what I wrote, you should have seen that I wrote
> > try_COMPILE(), not try_RUN().
> 
> Right. But i am still missing the WHY? 

It would make the version detection independent from in which file the 
version-define is located.

> Yes we can do that. But on cross
> compiles that means no version information. So will you just accept that or
> keep the current code as fallback? If so then why even add the other. If
> not why is that acceptable if there is a perfectly working cross compile
> solution.

try_compile() works perfectly fine with cross compiling, it is only running an 
executable which is a problem with cross compiling.

Alex


More information about the Kde-buildsystem mailing list