[PATCH] FindXine: Make version detection work with xine >= 1.2.0.

Alexander Neundorf neundorf at kde.org
Thu Jan 26 20:44:41 UTC 2012


On Thursday 26 January 2012, Michael Jansen wrote:
> On Thursday, January 26, 2012 08:53:40 PM Alexander Neundorf wrote:
> > On Thursday 26 January 2012, Raphael Kubo da Costa wrote:
> > > Alexander Neundorf <neundorf at kde.org> writes:
> > > > Another idea would be to try_compile() a small binary and turn the
> > > > version numbers into a string by doing this, and the parsing that
> > > > string out of the executable.
> > > > This is what cmake does e.g. for determining the type sizes.
> > > 
> > > I'm fine with either option. Do you prefer the try_compile() version or
> > > can I commit this version?
> > 
> > I'm fine with committing this one.
> > If you have time, you can give the try_compile version a try.
> 
> Why? Interested in  breaking cross compiles?

I'd appreciate a somewhat more constructive tone.

> I see not other point in doing it.

In case you read what I wrote, you should have seen that I wrote 
try_COMPILE(), not try_RUN().

Alex


More information about the Kde-buildsystem mailing list