Check for off_t 64bits in FindKDE4Internal.cmake ?
Alexander Neundorf
neundorf at kde.org
Fri Feb 17 12:10:11 UTC 2012
Hi Dirk,
I'm looking through FindKDE4Internal.cmake, preparing it for KDE frameworks.
If found this commit from you:
http://quickgit.kde.org/index.php?p=kdelibs.git&a=commitdiff&h=ef244b3b241f20f0e50431a82efe6d4ddb54ea74&hp=1eccc216ef4f70f4ed195561c9a0abd7b5c89626
It adds a test whether off_t can hold 9223372036854775807, and if not, adds
-D_FILE_OFFSET_BITS=64 .
Wouldn't it be good enough to check whether off_t is 8 byte ?
Or, do you remember for which compiler or compiler version this was ?
Also, why not simply always adding -D_FILE_OFFSET_BITS=64 , as we do with
-D_LARGEFILE64_SOURCE ?
Alex
More information about the Kde-buildsystem
mailing list