Review Request: Fix kwin build with GLES

[Michael Palimaka]

> On April 12, 2012, 4:38 p.m., Martin Gräßlin wrote:
> > could you please provide a build error without the patch? I somehow doubt that this is the right fix for the build error you experience.

This is the error with OpenGL off and GLES on:

CMakeFiles/kcm_kwincompositing.dir/__/__/compositingprefs.o: In function `KWin::CompositingPrefs::hasGlx()':
compositingprefs.cpp:(.text+0x2b1): undefined reference to `glXQueryExtension'
CMakeFiles/kcm_kwincompositing.dir/__/__/compositingprefs.o: In function `KWin::CompositingPrefs::deleteGLXContext()':
compositingprefs.cpp:(.text+0xb36): undefined reference to `glXDestroyContext'
CMakeFiles/kcm_kwincompositing.dir/__/__/compositingprefs.o: In function `KWin::CompositingPrefs::initGLXContext()':
compositingprefs.cpp:(.text+0x10a9): undefined reference to `glXChooseVisual'
compositingprefs.cpp:(.text+0x10cc): undefined reference to `glXCreateContext'
compositingprefs.cpp:(.text+0x11a4): undefined reference to `glXMakeCurrent'
compositingprefs.cpp:(.text+0x1425): undefined reference to `glXChooseVisual'

and so on.

The only call in compositingprefs.cpp to glXQueryExtension is wrapped in #ifndef KWIN_HAVE_OPENGLES which is why I believed -DKWIN_HAVE_OPENGLES was not being passed in these circumstances.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104558/#review12361
-----------------------------------------------------------


On April 12, 2012, 4:08 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104558/
> -----------------------------------------------------------
> 
> (Updated April 12, 2012, 4:08 p.m.)
> 
> 
> Review request for Build System and kwin.
> 
> 
> Description
> -------
> 
> When compiling kwin with GLES and without OpenGL, build fails because some parts do not realise that GLES is being used. This is because of KWIN_HAVE_OPENGLES_COMPOSITING being previously removed in 026e0f418d27466a6fe855bbe95a50ea5dd71b4b and some references being missed.
> 
> This patch switches the conditional to OPENGLES_FOUND, so that -DKWIN_HAVE_OPENGLES is again passed to the build disabling OpenGL-only features.
> 
> 
> Diffs
> -----
> 
>   kwin/effects/CMakeLists.txt 6f0ef11e87c6cb5895c5843fa5bb91cf72a6e800 
>   kwin/kcmkwin/kwincompositing/CMakeLists.txt 2d420c06941138eefb7058458549da4df42bd70a 
>   kwin/kcmkwin/kwinscreenedges/CMakeLists.txt 282735087ba7ecd37ec96bdc05e8ef0a03e4dc8e 
> 
> Diff: http://git.reviewboard.kde.org/r/104558/diff/
> 
> 
> Testing
> -------
> 
> Builds with OpenGL on & GLES off, OpenGL off & GLES on, and both OpenGL & GLES on complete as expected. In each case, the appropriate OpenGL or GLES-specific libraries were built.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20120412/cf8d5817/attachment.html>