<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104558/">http://git.reviewboard.kde.org/r/104558/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 12th, 2012, 4:38 p.m., <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">could you please provide a build error without the patch? I somehow doubt that this is the right fix for the build error you experience.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the error with OpenGL off and GLES on:
CMakeFiles/kcm_kwincompositing.dir/__/__/compositingprefs.o: In function `KWin::CompositingPrefs::hasGlx()':
compositingprefs.cpp:(.text+0x2b1): undefined reference to `glXQueryExtension'
CMakeFiles/kcm_kwincompositing.dir/__/__/compositingprefs.o: In function `KWin::CompositingPrefs::deleteGLXContext()':
compositingprefs.cpp:(.text+0xb36): undefined reference to `glXDestroyContext'
CMakeFiles/kcm_kwincompositing.dir/__/__/compositingprefs.o: In function `KWin::CompositingPrefs::initGLXContext()':
compositingprefs.cpp:(.text+0x10a9): undefined reference to `glXChooseVisual'
compositingprefs.cpp:(.text+0x10cc): undefined reference to `glXCreateContext'
compositingprefs.cpp:(.text+0x11a4): undefined reference to `glXMakeCurrent'
compositingprefs.cpp:(.text+0x1425): undefined reference to `glXChooseVisual'
and so on.
The only call in compositingprefs.cpp to glXQueryExtension is wrapped in #ifndef KWIN_HAVE_OPENGLES which is why I believed -DKWIN_HAVE_OPENGLES was not being passed in these circumstances.</pre>
<br />
<p>- Michael</p>
<br />
<p>On April 12th, 2012, 4:08 p.m., Michael Palimaka wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Build System and kwin.</div>
<div>By Michael Palimaka.</div>
<p style="color: grey;"><i>Updated April 12, 2012, 4:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When compiling kwin with GLES and without OpenGL, build fails because some parts do not realise that GLES is being used. This is because of KWIN_HAVE_OPENGLES_COMPOSITING being previously removed in 026e0f418d27466a6fe855bbe95a50ea5dd71b4b and some references being missed.
This patch switches the conditional to OPENGLES_FOUND, so that -DKWIN_HAVE_OPENGLES is again passed to the build disabling OpenGL-only features.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds with OpenGL on & GLES off, OpenGL off & GLES on, and both OpenGL & GLES on complete as expected. In each case, the appropriate OpenGL or GLES-specific libraries were built.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/CMakeLists.txt <span style="color: grey">(6f0ef11e87c6cb5895c5843fa5bb91cf72a6e800)</span></li>
<li>kwin/kcmkwin/kwincompositing/CMakeLists.txt <span style="color: grey">(2d420c06941138eefb7058458549da4df42bd70a)</span></li>
<li>kwin/kcmkwin/kwinscreenedges/CMakeLists.txt <span style="color: grey">(282735087ba7ecd37ec96bdc05e8ef0a03e4dc8e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104558/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>