Review Request: Use exported targets the right way.

Raphael Kubo da Costa rakuco at freebsd.org
Wed Apr 11 05:05:04 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104545/
-----------------------------------------------------------

Review request for Build System and Trever Fischer.


Description
-------

Besides the exported targes file and the Config file having different purposes, so far applications wishing to use libkcompactdisc (such as kscd) had to use the full imported target name (which was weirdly named `KDE::Libkcompactdisckcompactdisc') instead of a variable such as `LIBKCOMPACTDISC_LIBRARIES'.
    
We now have a LibkcompactdiscConfig.cmake.in file which is used to generate a proper Config file. It currently defines the `LIBKCOMPACTDISC_INCLUDE_DIRS' and `LIBKCOMPACTDISC_LIBRARIES' variables and includes the exported targets file, which is now named LibkcompactdiscTargets.cmake.


Diffs
-----

  CMakeLists.txt b41dbf5 
  LibkcompactdiscConfig.cmake.in PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/104545/diff/


Testing
-------

With the analogous change <https://git.reviewboard.kde.org/r/104544/> made to libkcddb I can finally build kscd again.


Thanks,

Raphael Kubo da Costa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20120411/534ea85f/attachment.html>


More information about the Kde-buildsystem mailing list