Review Request: Use exported targets the right way.

Raphael Kubo da Costa rakuco at freebsd.org
Wed Apr 11 04:51:12 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104544/
-----------------------------------------------------------

Review request for Build System and Trever Fischer.


Description
-------

Besides the exported targes file and the Config file having different purposes, so far applications wishing to use libkcddb (such as kscd) had to use the full imported target name (which was weirdly named `KDE::Libkcddbkcddb') instead of a variable such as `LIBKCDDB_LIBRARIES'.
    
We now have a LibkcddbConfig.cmake.in file which is used to generate a proper Config file. It currently defines the `LIBKCDDB_INCLUDE_DIRS' and `LIBKCDDB_LIBRARIES' variables and includes the exported targets file, which is now named LibkcddbTargets.cmake.


Diffs
-----

  CMakeLists.txt 5ad2eb1 
  LibkcddbConfig.cmake.in PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/104544/diff/


Testing
-------

With the analogous change made to libkcompactdisc I can finally build kscd again.


Thanks,

Raphael Kubo da Costa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20120411/3f4e6aea/attachment.html>


More information about the Kde-buildsystem mailing list