[kdelibs] cmake/modules: A FindXYZ.cmake file should not use macro_log_feature imho.

Michael Jansen kde at michael-jansen.biz
Thu Jun 30 22:58:33 CEST 2011


On Thursday 30 June 2011 22:08:52 Alexander Neundorf wrote:
> On Wednesday 29 June 2011, Michael Jansen wrote:
> > Git commit 02e1ba357e730bc6e4a1aa7bf496e880209fdf9d by Michael Jansen.
> > Committed on 29/06/2011 at 17:28.
> > Pushed by mjansen into branch 'master'.
> > 
> > A FindXYZ.cmake file should not use macro_log_feature imho.
> 
> Actually I don't agree.
> (but I don't object the patch)
> 
> I think ideally, each find_package() call should result in the respective
> information recorded somewhere (i.e. homepage of the project and what that
> thing is).

I agree. But only on the first level. Here we have:

MyApp: find_package(Nepomuk)
FindNepomuk.cmake: find_package(Soprano)

So what do you expect the user to see?

The following optional packages were not found:


More information about the Kde-buildsystem mailing list