[Kde-bindings] Re: Review Request: Make SIP files install dir relative to CMAKE_INSTALL_PREFIX

[Alexander Neundorf]

On Saturday 09 July 2011, Michael Jansen wrote:
> On Saturday 09 July 2011 22:13:24 Simon Edwards wrote:
> > On 07/09/2011 08:07 PM, Artem Serebriyskiy wrote:
> > >   Description
> > > 
> > > Replace SIP_DEFAULT_SIP_DIR with ${CMAKE_INSTALL_PREFIX}/share/sip.
> > > Otherwise installing pykde localy with system-wide SIP was impossible
> > 
> > Can you first please describe what problem this patch tries to solve?
> > There is probably a way of doing what you want already.
> 
> Yes there is. But there is a rule in kde (and all other buildsystems).
> NEVER install anything outside of CMAKE_INSTALL_PREFIX by default.
> 
> NEVER.
> 
> So i am for this patch and i guess the kde-buildsystem mailing list too.

Yes. By default everything must go inside CMAKE_INSTALL_PREFIX.

This is done now also e.g. in phonon, for the installation of the Qt designer 
plugins. Additionally we added a check there whether the install dir is the 
same as the Qt system install dir, and if not, print a warning message what to 
do.

Alex