[FindSoprano] SOPRANO_MIN_VERSION isn't correctly check

[Romain Perier]

Le mardi 26 octobre 2010 10:51:07, vous avez écrit :
> Hey,
> 
> SOPRANO_MIN_VERSION isn't correctly check in FindSoprano.cmake
> by find_package_handle_standard_args, causing build failure with the
> lastest soprano (2.5.2). In this case, nepomuk is built anyway and
> shouldn't. The problem is due to find_package_handle_standard_args() which
> should have the "VERSION_ARG" argument in order to check if at least
> SOPRANO_MIN_VERSION is found, otherwise Soprano is converted to uppercase
> and SOPRANO_FOUND is set to TRUE, and  necessarily Soprano_FOUND too.
> Also in FindNepomuk.cmake find_package() should check for
> SOPRANO_MIN_VERSION imho (however I'm not 100% sure about that, because
> it'll be installed on the system... any other ideas ?)
> 
> See a patch in attachment, feel free to comment it.
> 
> Regards,
> Romain

Arff noob mistake , this is the "second mode" for 
find_package_handle_standard_args(), so we've to use REQUIRED_VARS otherwises 
it fails randomly.

see the correct patch in attachment
Regards,
Romain
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdelibs_Soprano_check_correct_version.patch
Type: text/x-patch
Size: 3036 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20101026/0a3e7d94/attachment.patch