[FindSoprano] SOPRANO_MIN_VERSION isn't correctly check

PERIER Romain romain.perier at gmail.com
Tue Oct 26 10:51:07 CEST 2010


Hey,

SOPRANO_MIN_VERSION isn't correctly check in FindSoprano.cmake
by find_package_handle_standard_args, causing build failure with the lastest
soprano (2.5.2). In this case, nepomuk is built anyway and shouldn't.
The problem is due to find_package_handle_standard_args() which should have
the "VERSION_ARG" argument in order to check if at least SOPRANO_MIN_VERSION
is found, otherwise Soprano is converted to uppercase and SOPRANO_FOUND is
set to TRUE, and  necessarily Soprano_FOUND too.
Also in FindNepomuk.cmake find_package() should check for
SOPRANO_MIN_VERSION imho (however I'm not 100% sure about that, because
it'll be installed on the system... any other ideas ?)

See a patch in attachment, feel free to comment it.

Regards,
Romain
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-buildsystem/attachments/20101026/62005e5d/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdelibs_Soprano_check_correct_version.patch
Type: text/x-patch
Size: 3238 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20101026/62005e5d/attachment.patch 


More information about the Kde-buildsystem mailing list