Build error in kdeplasma-addons

[Pavel Heimlich, a.k.a. hajma]

2010/5/6 Alexander Neundorf <neundorf at kde.org>:
> On Wednesday 05 May 2010, Alexander Neundorf wrote:
>> On Tuesday 04 May 2010, Ivan Čukić wrote:
>> > On Tuesday, 4. May 2010. Alexander Neundorf wrote:
>> > > Hi Ivan,
>> > >
>> > > the lancelot-datamodels library currently doesn't compile if not all
>> > > KDE modules have been installed to the same prefix:
>> > > http://my.cdash.org/viewBuildError.php?buildid=64257
>> > >
>> > > The problem is that you have the following code in your CMakeLists.txt:
>> > >
>> > > set(screensaver_xml
>> > >
>> > > ${KDE4WORKSPACE_DBUS_INTERFACES_DIR}/org.freedesktop.ScreenSaver.xml)
>> >
>> > The error should only occur when missing the above file - the rest of
>> > them have a fall-back in the libs/lancelot-datamodels/external directory.
>> >
>> > I'll add the fallback for screensaver as well.
>>
>> Hmm, better, but still not correct.
>> DBUS_INTERFACES_INSTALL_DIR is the wrong variable to use.
>> You should add a
>> find_package(KDE4Workspace)
>> and then use ${KDE4WORKSPACE_DBUS_INTERFACES_DIR}. If ScreenSaver.xml is
>> installed, it will be found then.
>>
>> For the other xml files using ${KDE4_DBUS_INTERFACES_DIR} (which is the
>> dbus interface dir from kdelibs) should still be better than using
>> ${DBUS_INTERFACES_INSTALL_DIR}, which is the dbus install dir of kdeplasma
>> (which may be in a completely different place).
>
> Can you please have a look ?
> It's still failing:
> http://my.cdash.org/viewBuildError.php?buildid=64787
>
> Alex

Hi,

there seems to be some issue in the libs/lancelot-datamodels/CMakeLists.txt
applying the below change, the build proceeds much more further:

$ svn diff libs/lancelot-datamodels/CMakeLists.txt
Index: libs/lancelot-datamodels/CMakeLists.txt
===================================================================
--- libs/lancelot-datamodels/CMakeLists.txt     (revision 1129790)
+++ libs/lancelot-datamodels/CMakeLists.txt     (working copy)
@@ -96,7 +96,7 @@

 set(screensaver_xml
${DBUS_INTERFACES_INSTALL_DIR}/org.freedesktop.ScreenSaver.xml)
 if (NOT EXISTS ${screensaver_xml})
-   set(kopete_xml external/org.freedesktop.ScreenSaver.xml)
+   set(screensaver_xml external/org.freedesktop.ScreenSaver.xml)
 endif (NOT EXISTS ${screensaver_xml})
 qt4_add_dbus_interface(lancelot_datamodels_LIB_SRCS
${screensaver_xml} screensaver_interface)