Proposal to change kdelibs/cmake/modules/FindGettext.cmake

[Alvaro Soliverez]

Hello,

2010/5/20 Alexander Neundorf <neundorf at kde.org>:
> On Thursday 20 May 2010, you wrote:
>> Hi guys,
>>
>> we - the KMyMoney team - ran into a problem with the current switch to
>> cmake 2.6.4 and the tarballs generated by the createtarball script.
>>
>> The problem is, that of cmake 2.6.4 no duplicate targets are allowed w/o
>> turning off policy CMP0002. Turning off the policy could serve a
>> work-around on a per project basis, but a cleaner solution would be to fix
>> FindGettext.cmake.
>
> In FindKDE4Internal.cmake CMP0002 is set to OLD.
> Somehow you seem to be setting it to NEW or WARN again.
> Do you maybe have a cmake_minimum_required(VERSION ... ) somewhere after
> find_package(KDE4) ?
>

Actually, it's right there at the beginning of the CMakeLists.txt.
Does that supersede the policy setting of FindGettext?


>> The proposed solution is to add an underscore and the language code for the
>> generation of the 'pofiles' target, so that it becomes e.g. 'pofiles_de'
>> for German and 'pofiles_fr' for French.
>
> Sounds good, will check the details...
>
>> Would that modification break anything that I am not aware of? I tested it
>> in our project and it does not break anything for us. Please confirm and I
>> will add it to SVN trunk myself.

Thanks!