DocBook XML & XSL: new dependencies

Luigi Toscano luigi.toscano at tiscali.it
Wed May 19 01:00:44 CEST 2010


Alexander Neundorf wrote:
>
> I had a quick look at both files (XML and XSLT).
> Only a few comments:
> you should add
> include(FindPackageHandleStandardArgs)
> , otherwise, as it is now, both files rely on that some other file which has
> been processed before has already done that.
Done.

>
> I think the foreach()-loop in both files should/could be put in a
> if(NOT DOCBOOKXSL_DIR) / if(NOT DOCBOOKXML_CURRENTDTD_VERSION)
> so the globbing is only executed when the find_path() calls later on will
> actually do something.
Should be fixed now (even if it needs some testing on distributions which make 
uses of that code).

Ciao
-- 
Luigi


More information about the Kde-buildsystem mailing list