DocBook XML & XSL: new dependencies

[Luigi Toscano]

Alexander Neundorf wrote:
> On Thursday 06 May 2010, Luigi Toscano wrote:
>> Alexander Neundorf wrote:
>>   >  On Tuesday 04 May 2010, Luigi Toscano wrote:
>>   >>  as I announced on kde-core-devel[1], I'm working to remove the embedded
>>   >>  copies of XML and XSLT files from kdelibs/kdoctools. This process will
>>   >>  introduce two external dependencies; I'd like to complete the migration
>>   >>  before the release of 4.5, so the proposed Find*.cmake modules for
>>   >>  kdelibs
>>   >
>>   >  Are the two find-modules supposed to be installed ?
>>   >  IOW, are docbookxml and docbook xsl only required when building kdelibs
>>   >  or for all other KDE modules too ?
>>
>> They are required whenever you need to compile documentation, but the path
>
> This means they are required for every KDE module ?
No: the path to the XML DTD and to XSL stylesheet will be hardcoded in some 
files (meinproc executable, kdex.dtd). Other KDE modules/programs won't need 
to use FindDocBookX* just to generate the documentation.

>> to the DTDs/XMLT will be discovered and hardcoded (like now), so exporting
>> them shouldn't be needed.
>
> I don't understand completely ?
> What will be hardcoded and where ? And what do you mean with exporting ?
Installing as part of the public API. Is there another way for other modules 
to use the variables defined by one of these two cmake modules? Like those ones:
>> But there are two possible consumer for them: -
>> the xmlcheck plugin for kate (kdesdk) which needs to be touched anyway
>> because refers to the internal copy of XML DTDs, and
>> - the docbook exporter for umbrello, which does the same for xslt.


>>   >  Things which should be changed:
>>   >  * use the find_package_handle_standard_args() macro for the status
>>   >  output at the end and setting<package>_FOUND.
>>
>> Is it possible to specify a custom success message, other than the failure
>> message?
>
> Currently not. What would you like to see ?
I was thinking about a more complex message, but the first variable in the 
list is printed with the name of the dependency, so this point is not important.

> [...]
> But when using find_package_handle_standard_args() this is not necessary at
> all, it remembers what it has print the last time and only prints a status
> message again if the output changes.
Done.

I applied the required changes, as you can see from the attachment.

Regards,
-- 
Luigi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: FindDocBookXML.cmake
Type: text/x-cmake
Size: 1971 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20100507/f6002d33/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: FindDocBookXSL.cmake
Type: text/x-cmake
Size: 937 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20100507/f6002d33/attachment-0001.bin