DocBook XML & XSL: new dependencies

[Alexander Neundorf]

On Thursday 06 May 2010, Luigi Toscano wrote:
> Alexander Neundorf wrote:
>  > On Tuesday 04 May 2010, Luigi Toscano wrote:
>  >> as I announced on kde-core-devel[1], I'm working to remove the embedded
>  >> copies of XML and XSLT files from kdelibs/kdoctools. This process will
>  >> introduce two external dependencies; I'd like to complete the migration
>  >> before the release of 4.5, so the proposed Find*.cmake modules for
>  >> kdelibs
>  >
>  > Are the two find-modules supposed to be installed ?
>  > IOW, are docbookxml and docbook xsl only required when building kdelibs
>  > or for all other KDE modules too ?
>
> They are required whenever you need to compile documentation, but the path

This means they are required for every KDE module ?

> to the DTDs/XMLT will be discovered and hardcoded (like now), so exporting
> them shouldn't be needed. 

I don't understand completely ?
What will be hardcoded and where ? And what do you mean with exporting ?

> But there are two possible consumer for them: -
> the xmlcheck plugin for kate (kdesdk) which needs to be touched anyway
> because refers to the internal copy of XML DTDs, and
> - the docbook exporter for umbrello, which does the same for xslt.

>  > Things which should be changed:
>  > * use the find_package_handle_standard_args() macro for the status
>  > output at the end and setting<package>_FOUND.
>
> Is it possible to specify a custom success message, other than the failure
> message?

Currently not. What would you like to see ?

>  > * I would remove the shortcuts at the top of the file "if
>  > (DOCBOOKXSL_DIR)", the results of the find_file/path/program/library()
>  > commands are cached, so I don't think it really makes it noticable
>  > faster.
>
> Which component/function sets xyz_FIND_QUIETLY, then?

Ahh, now I understand...
No, <package>_FIND_QUIETLY is set by the find_package() command if it has been 
called with the QUIET argument.
That <package>_FIND_QUIETLY is set explicitely in some of our cmake files is 
more a hack to make the logic later on not print status messages anymore.

But when using find_package_handle_standard_args() this is not necessary at 
all, it remembers what it has print the last time and only prints a status 
message again if the output changes.

Alex