Do not force CMAKE_COLOR_MAKEFILE=ON

[Maciej Mrozowski]

On Sunday 27 of June 2010 22:30:14 Alexander Neundorf wrote:
> On Sunday 27 June 2010, Maciej Mrozowski wrote:
> > On Sunday 27 of June 2010 09:36:04 Andreas Pakulat wrote:
> > > On 26.06.10 20:03:33, Maciej Mrozowski wrote:
> > > > I'm going to commit the following, any objections?
> > > > No way to actually disable colors when building KDE4 apps otherwise.
> > > > Colors are enabled by default in CMake version we depend on.
> > > 
> > > Just out of curiosity: Why do you need to explicitly disable colors?
> > 
> > Well, first because if there's such option it should be working.
> > But primarily, sometimes there's need to avoid Esc characters being
> > thrown to terminal, especially when its output is to be logged:
> > 
> > Scanning dependencies of target kde-cp_automoc
> > Scanning dependencies of target kde-mv_automoc
> > Generating kioclient.moc
> > Generating kioclient.moc
> > [  0%] [  0%] Built target kde-mv_automoc
> > Built target kde-cp_automoc
> 
> There is code in cmake which tries to detect whether color can be used or
> not. E.g. when I do "make > make.log 2>&1" there are no escape codes on
> the logged file.
> In which case do you get this ?

Gentoo portage either allocates virtual terminal for console output or does 
something similar to provide console output and build log at the same time. 
Just redirecting output to file would work but it's not the case.
Let me reverse the question: why do you need to explicitly enable colours? :)

(sorry Alex for 'private' email)

-- 
regards
MM