KDE/kdelibs/cmake/modules

Alexander Neundorf neundorf at kde.org
Mon Jul 26 21:22:52 CEST 2010


On Sunday 18 July 2010, Romain Pokrzywka wrote:
> SVN commit 1151234 by pokrzywka:
>
> install FindWcecompat.cmake (needed by FindKDEWin.cmake)

Hi,

FindWcecompat.cmake looks somewhat strange.
It seems to contain the same code twice ?

Also it should have been posted for review first before adding it to 
kdelibs/cmake/modules/ and installing it 
(http://techbase.kde.org/Policies/CMake_Commit_Policy).

The 
"if(WCECOMPAT_INCLUDE_DIR AND WCECOMPAT_LIB_FOUND)
  set(Wcecompat_FIND_QUIETLY TRUE)
endif(WCECOMPAT_INCLUDE_DIR AND WCECOMPAT_LIB_FOUND)"

part is not necessary, it can be removed.
find_package_handle_standard_args() remembers what it printed the last time 
and only prints again if something has changed, so the logic above is not 
necessary.

Alex


More information about the Kde-buildsystem mailing list