Serializing possibly resource-intensive tasks such as meinproc

Alexander Neundorf neundorf at kde.org
Mon Jan 11 21:29:17 CET 2010


On Friday 08 January 2010, Lubos Lunak wrote:
> On Thursday 07 of January 2010, Oswald Buddenhagen wrote:
> > On Thu, Jan 07, 2010 at 04:20:39PM +0100, Lubos Lunak wrote:
> > >  I would like to commit the attached kdelibs/icecream patches, in order
> > > to avoid running into pathetic OOM situations on Linux.
> >
> > i'll comment on the icecream patch when i find the time. ping me on irc
> > if i don't.
> >
> > but i find the kde part "somewhat" backwards. for one, covering just
> > meinproc is a bit shortsighted (i bet a few webkit links can blow your
> > box just as nicely :D).
>
>  They can't, because I don't run into 20 webkit links at the same time. I
> had the last problem with 20 meinproc4 instances one hour ago. And since
> icecream currently serializes down to one task even if the machine has more
> cores, I don't want to cover more than what's necessary.
>
> > second, having just that tool support
> > "hardcoded" is ugly. third, the assumption that a found icecc means that
> > it should be automatically used is plain wrong.
> >
> > a more generic solution would be recognizing a KDE4_TOOL_WRAPPER cmake
> > variable and prepending it to all non-c-compiler executables.
>
>  How about the attached patch then?

Looks quite ok.
The name "KDE4_SERIALIZE_TOOL" is quite generic, but in the patch it is used 
only for meinproc4, so this doesn't really match.

I'm not sure using LD_PRELOAD is really a "cleaner" solution.

Alex


More information about the Kde-buildsystem mailing list