KDE/kdelibs/cmake/modules

[Dario Freddi]

In data giovedì 03 settembre 2009 20:24:13, Alexander Neundorf ha scritto:
> > Roger that
> 
> I guess this means ok ?

Yes :)

> The variables is set, but neither documented nor used.
> Maybe just remove it ?
> If it stays in that file, it should be documented and it really should get
>  the POLKITQT_ prefix, so it is clear where it comes from.

Will get documented and will get the prefix

> 
> Where is POLKITQT_PREFIX set ?

Should be set by pkgconfig, so it would become PC_blabla

> 
> > > dbus_add_activation_system_service() ?
> >
> > This one is actually a modification of dbus_add_activation_service (that
> > is somewhere else I don't remember now)
> 
> Can you please check where this comes from ?
> Should be FindDBus.cmake...

Can't really find FindDBus.cmake, I will search later

> 
> > that adds an activation service on the
> > system bus, not the session one. This was done to keep naming consistent,
> > but could probably be moved somewhere else.
> 
> FindDBus.cmake looks like a good candidate ;-)
> (this depends on where it comes from, not who uses it, the same as all
>  classes coming from Qt start with "Q", even if they are used in KDE "K"
> programs ;-) )

OK, makes sense :D

> 
> Alex
> 

-- 
-------------------

Dario Freddi
KDE Developer
GPG Key Signature: 511A9A3B
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20090903/8fbf42df/attachment-0001.sig