[PATCH] Improve KAuth backend selection and let the packager decide which KAuth backend to compile
Alexander Neundorf
neundorf at kde.org
Tue Oct 20 19:43:34 CEST 2009
On Tuesday 20 October 2009, Dario Freddi wrote:
> Sorry for the late reply - I forgot to say I'm not on this list, so please
> CC me in replies.
>
> Anyway, attached comes an updated patch with more documentation and CACHE
> STRING
+if(NOT KAUTH_BACKEND OR KAUTH_BACKEND STREQUAL "")
+ if (APPLE)
+ set (KAUTH_BACKEND "Apple")
+ elseif (UNIX)
The comparison with the empty string is not necessary, just doing
+if(NOT KAUTH_BACKEND)
should be enough, since an empty string is also evaluated as false.
And maybe I would make KAUTH_BACKEND case-insensitive, so that "Fake", "FAKE"
and "fake" would be all recognized (do a STRING(TOUPPER ) once).
Looks good otherwise I'd say.
Alex
More information about the Kde-buildsystem
mailing list