KDE/kdelibs/cmake/modules

Alexander Neundorf neundorf at kde.org
Wed Nov 25 22:08:20 CET 2009


Hi Sebastian,

On Wednesday 25 November 2009, Sebastian Trueg wrote:
> SVN commit 1054294 by trueg:
>
> Added macro to find the new shared-desktop-ontologies package
>
>  M  +1 -0      CMakeLists.txt
>  M  +7 -1      FindNepomuk.cmake
>  A             FindSharedDesktopOntologies.cmake

please be more careful when working in kdelibs with the cmake modules.
We have a commit policy there:
http://techbase.kde.org/Policies/CMake_Commit_Policy

The FindSharedDesktopOntologies.cmake was not sent to kde-buildsystem for 
review, and it was not discussed whether this module needs to be installed.

The file as it is, is not acceptable, see 
http://techbase.kde.org/Policies/CMake_Coding_Style#.28Not.29_Using_pkg-config

Please revert this commit and send a file for reviewing to kde-buildsystem 
still today.

Please also explain and fix the FindKonto.cmake/FindKNepomuk.cmake issue still 
today.

Alex


More information about the Kde-buildsystem mailing list