outdated FindQt4.cmake in kdelibs
Alexander Neundorf
neundorf at kde.org
Thu Nov 5 19:01:10 CET 2009
On Thursday 05 November 2009, you wrote:
> > ...but a big thing which is left is synchronizing how the components are
> > found.
> > This has diverged quite a bit between the two versions and I didn't get
> > around to do that yet.
>
> I think you are talking about this:
> http://public.kitware.com/Bug/view.php?id=8542
>
> I wrote the "new" component detection and it's not really different.
> It's only it now supports COMPONENTS in addition to SET( QT_USE_BLAH 1
> ). The patches there may be useful when updating KDE's FindQt4.cmake
> to match CMake's.
Not only that, actually the whole logic how include dirs and libs are
searched.
> Also, when (if) the merging between CMake's FindQt4.cmake and KDE's
> FindQt4.cmake is done, can we please get the merged one to CMake CVS
I'm doing the merging always both ways in general, except the stuff where I'm
not sure it makes sense for the broader public.
> and use CMake's as the canonical one from now on?
That's a more long term goal, since this implies that we will require that of
version of cmake which comes with the merged version, i.e. at most 2.8.1.
Upgrading the required cmake version just for the FindQt4.cmake would not make
sense I'd say, there must be more reasons to justify an upgrade.
Alex
More information about the Kde-buildsystem
mailing list