[PATCH] Eliminating confusion after pkgconfig fails to find packages

Allen Winter winter at kde.org
Wed Mar 11 11:50:17 CET 2009


On Tuesday 10 March 2009 9:38:48 pm David Jarvie wrote:
> On Wednesday 11 Mar 2009 00:53:28 David Jarvie wrote:
> > On Tuesday 10 Mar 2009 19:58:39 Alexander Neundorf wrote:
> > > On Tuesday 10 March 2009, David Jarvie wrote:
> > > > On Mon 9 March 2009 23:32:48 Alexander Neundorf wrote:
> > >
> > > ...
> > >
> > > > > It's no (real) problem to add a copy of FindPkgConfig.cmake again to
> > > > > kdelibs/cmake/modules/.
> > > >
> > > > OK, here's a patch to FindPkgConfig.cmake (from cmake 2.6.2) to provide
> > > > a QUIET option for pkg_check_modules(). For example,
> > > >
> > > > pkg_check_modules(PC_QIMAGEBLITZ QUIET qimageblitz)
> > > >
> > > > OK to commit to kdelibs/cmake/modules? If so, I'll do a patch to
> > > > convert the relevant FindXXXX.cmake files.
> > >
> > > I didn't test it, but in general it looks good.
> > > You may want to add a sentence what the new option does to the
> > > documentation at the top.
> > > So, from my side, go ahead and commit if it works for you.
> >
> > Now committed, including documentation.
> 
> I now attach patches for kdelibs, kdebase and kdepim to use the QUIET option 
> described above to suppress duplicate 'not found' messages from pkgconfig. I 
> have tried to ensure that this option is only used in cmake scripts in which 
> the pkgconfig messages would not add any information compared to the messages 
> output once the patches have been applied.
> 
> OK to commit?
> 
Will these changes be backwards compatible against a 4.2 installation?
i.e. if I try to build kdepim trunk against an installed kdelibs 4.2?


-- 
Allen Winter | Software Engineer | 1-888-872-9339
KDAB, Inc. | "Platform-independent software solutions"
http://kdab.com | 1-866-777-5322 (US) | +46-563-540090 (Sweden)


More information about the Kde-buildsystem mailing list