[PATCH] Eliminating confusion after pkgconfig fails to find packages

David Jarvie djarvie at kde.org
Wed Mar 11 02:38:48 CET 2009


On Wednesday 11 Mar 2009 00:53:28 David Jarvie wrote:
> On Tuesday 10 Mar 2009 19:58:39 Alexander Neundorf wrote:
> > On Tuesday 10 March 2009, David Jarvie wrote:
> > > On Mon 9 March 2009 23:32:48 Alexander Neundorf wrote:
> >
> > ...
> >
> > > > It's no (real) problem to add a copy of FindPkgConfig.cmake again to
> > > > kdelibs/cmake/modules/.
> > >
> > > OK, here's a patch to FindPkgConfig.cmake (from cmake 2.6.2) to provide
> > > a QUIET option for pkg_check_modules(). For example,
> > >
> > > pkg_check_modules(PC_QIMAGEBLITZ QUIET qimageblitz)
> > >
> > > OK to commit to kdelibs/cmake/modules? If so, I'll do a patch to
> > > convert the relevant FindXXXX.cmake files.
> >
> > I didn't test it, but in general it looks good.
> > You may want to add a sentence what the new option does to the
> > documentation at the top.
> > So, from my side, go ahead and commit if it works for you.
>
> Now committed, including documentation.

I now attach patches for kdelibs, kdebase and kdepim to use the QUIET option 
described above to suppress duplicate 'not found' messages from pkgconfig. I 
have tried to ensure that this option is only used in cmake scripts in which 
the pkgconfig messages would not add any information compared to the messages 
output once the patches have been applied.

OK to commit?

-- 
David Jarvie.
KAlarm author and maintainer.
http://www.astrojar.org.uk/kalarm
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdebase.diff
Type: text/x-patch
Size: 1747 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20090311/199739d3/attachment.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdelibs.diff
Type: text/x-patch
Size: 10462 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20090311/199739d3/attachment-0001.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdepim.diff
Type: text/x-patch
Size: 490 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20090311/199739d3/attachment-0002.diff 


More information about the Kde-buildsystem mailing list