on finding KDE4

[Aleix Pol]

That's weird :P

Well, do you want me to commit a fix or you're fixing it?

Take care!
Aleix

On Sun, Jun 28, 2009 at 10:25 AM, Alexander Neundorf <neundorf at kde.org>wrote:

> On Sunday 28 June 2009, Aleix Pol wrote:
> > hi,
> > while looking through the code looking for a bug i ran into this code:
> >
> > get_target_property(_importedConfigurations
> > ${KDE4_TARGET_PREFIX}kconfig_compiler IMPORTED_CONFIGURATIONS )
> > list(GET _importedConfigurations 0 _firstConfig)
> >
> > get_target_property(KDE4_KCFGC_EXECUTABLE
> > ${KDE4_TARGET_PREFIX}kconfig_compiler LOCATION_${firstConfig})
> > get_target_property(KDE4_MEINPROC_EXECUTABLE
> > ${KDE4_TARGET_PREFIX}meinproc4        LOCATION_${firstConfig})
> > get_target_property(KDE4_MAKEKDEWIDGETS_EXECUTABLE
> > ${KDE4_TARGET_PREFIX}makekdewidgets   LOCATION_${firstConfig})
> >
> > Why isn't the property name like that (note the underscore)?
> > LOCATION_${_firstConfig}
>
> You are correct, this was wrong, I committed the fix to trunk and the 4.3
> branch.
>
> It still worked, because this was cmake was looking for the location of an
> not
> existing configuration, and if it does that, it returns the location for an
> arbitrary configuration.
>
> Alex
> _______________________________________________
> Kde-buildsystem mailing list
> Kde-buildsystem at kde.org
> https://mail.kde.org/mailman/listinfo/kde-buildsystem
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-buildsystem/attachments/20090628/a9827e9b/attachment.htm