That's weird :P<br><br>Well, do you want me to commit a fix or you're fixing it?<br><br>Take care!<br>Aleix<br><br><div class="gmail_quote">On Sun, Jun 28, 2009 at 10:25 AM, Alexander Neundorf <span dir="ltr"><<a href="mailto:neundorf@kde.org">neundorf@kde.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div><div></div><div class="h5">On Sunday 28 June 2009, Aleix Pol wrote:<br>
> hi,<br>
> while looking through the code looking for a bug i ran into this code:<br>
><br>
> get_target_property(_importedConfigurations<br>
> ${KDE4_TARGET_PREFIX}kconfig_compiler IMPORTED_CONFIGURATIONS )<br>
> list(GET _importedConfigurations 0 _firstConfig)<br>
><br>
> get_target_property(KDE4_KCFGC_EXECUTABLE<br>
> ${KDE4_TARGET_PREFIX}kconfig_compiler LOCATION_${firstConfig})<br>
> get_target_property(KDE4_MEINPROC_EXECUTABLE<br>
> ${KDE4_TARGET_PREFIX}meinproc4 LOCATION_${firstConfig})<br>
> get_target_property(KDE4_MAKEKDEWIDGETS_EXECUTABLE<br>
> ${KDE4_TARGET_PREFIX}makekdewidgets LOCATION_${firstConfig})<br>
><br>
> Why isn't the property name like that (note the underscore)?<br>
> LOCATION_${_firstConfig}<br>
<br>
</div></div>You are correct, this was wrong, I committed the fix to trunk and the 4.3<br>
branch.<br>
<br>
It still worked, because this was cmake was looking for the location of an not<br>
existing configuration, and if it does that, it returns the location for an<br>
arbitrary configuration.<br>
<br>
Alex<br>
_______________________________________________<br>
Kde-buildsystem mailing list<br>
<a href="mailto:Kde-buildsystem@kde.org">Kde-buildsystem@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kde-buildsystem" target="_blank">https://mail.kde.org/mailman/listinfo/kde-buildsystem</a><br>
</blockquote></div><br>