branches/KDE/4.3/kdelibs/cmake/modules

David Faure faure at kde.org
Mon Jul 13 00:36:19 CEST 2009


SVN commit 995533 by dfaure:

Always define MAKE_FOO_LIB, not only on Windows. This is used in konqueror to know when to enable KDE_TESTS_EXPORT.
What I don't understand, is why it worked before; konqprivate_export.h always relied on MAKE_KDEINIT_KONQUEROR_LIB...
(and without this commit, konqviewmgrtest failed with undefined symbol KonqSettings::self(), which is logical)
CCMAIL: kde-buildsystem at kde.org


 M  +5 -7      KDE4Macros.cmake  


--- branches/KDE/4.3/kdelibs/cmake/modules/KDE4Macros.cmake #995532:995533
@@ -574,13 +574,11 @@
       set_target_properties(${_target_NAME} PROPERTIES PREFIX "")
    endif (_first_SRC)
 
-   if (WIN32)
-      # for shared libraries/plugins a -DMAKE_target_LIB is required
-      string(TOUPPER ${_target_NAME} _symbol)
-      string(REGEX REPLACE "[^_A-Za-z0-9]" "_" _symbol ${_symbol})
-      set(_symbol "MAKE_${_symbol}_LIB")
-      set_target_properties(${_target_NAME} PROPERTIES DEFINE_SYMBOL ${_symbol})
-   endif (WIN32)
+   # for shared libraries/plugins a -DMAKE_target_LIB is required
+   string(TOUPPER ${_target_NAME} _symbol)
+   string(REGEX REPLACE "[^_A-Za-z0-9]" "_" _symbol ${_symbol})
+   set(_symbol "MAKE_${_symbol}_LIB")
+   set_target_properties(${_target_NAME} PROPERTIES DEFINE_SYMBOL ${_symbol})
 
 endmacro (KDE4_ADD_PLUGIN _target_NAME _with_PREFIX)
 


More information about the Kde-buildsystem mailing list