automoc4

[Alexander Neundorf]

On Thursday 08 May 2008, Matthias Kretz wrote:
> On Thursday 08 May 2008, Alexander Neundorf wrote:
...
> > I want to have a look at that in the next day.
> > Actually we must not remove anything from FindKDE4Internal.cmake (as e.g.
> > KDE4_AUTOMOC), since this breaks source compatiblity.
> > I'm not sure about the KDE4_SET/GET_TARGET_PROPERTY(), I don't think
> > anybody else uses them.
> > But anyway, I want to see if I can make it so that automoc4 is optional
> > for a few weeks and if it's not found the one from kdelibs is used. This
> > way developers will have more time to update.
> > So please don't commit this one yet.
>
> Yes, I considered my patch good enough for testing, not more.

Ok.

> I considered the removal of KDE4_AUTOMOC_EXECUTABLE from
> FindKDE4Internal.cmake as a change of internals. Sure, everything is
> accessible to others since this file is installed, but I would expect
> nobody to use that specific variable other than with the macros in
> KDE4Macros.cmake. And since FindKDE4Internal and KDE4Macros go together, if
> the latter stops using KDE4_AUTOMOC_EXECUTABLE, the former should be free
> to remove the check. IMHO.

Well, it's not that much different from removing a function from some header 
file.

> Same for KDE4_SET/GET_TARGET_PROPERTY(), that's an internal macro and I
> think I didn't document it either. I think it can be removed.

Although feeling bad about this, I'll think we'll try it for these two 
macros...

> Perhaps there needs to be some policy to mark macros as internal
> or "compatibility will be kept". For now nothing seems to be internal.

Yes, I'd suggest prefixing internal stuff with an underscore, everything else 
(which is documented) is public interface.

Alex