kde4_add_test is not sufficient

[Andreas Pakulat]

On 08.06.07 00:34:17, Alexander Neundorf wrote:
> On Thursday 07 June 2007 03:00, David Faure wrote:
> > The naming is a bit unfortunate IMHO. "kde4_add_test" is called this way
> > to look like "kde4_add_executable", i.e. "build this test program"
> > (which could be automated or interactive). But CMake's "add_test" means
> > "run this automated test", and the two macros look too much alike which
> > leads to confusion.
> >
> > Maybe kde4_add_test should be renamed to kde4_add_test_executable
> > at least (like kde4_add_kdeinit_executable).
> 
> That's just what I thought too, kde4_add_test_executable().
> 
> Beside that, maybe we're not using cmake/ctest optimal by testing via "make 
> test" but we should do "ctest <some fancy options>" instead...

I can't see any that would work without the add_test call.

> > To solve your problem, we could have kde4_add_unit_test I suppose,
> > which would do both (kde4_add_test_executable + add_test).
> 
> Not sure we need this. If it just adds add_test() to 
> kde4_add_test_executable() it might more confuse than help.

Well, kde4_add_unit_test is simply just a little convenience macro to
not having to remember to use both kde4_add_test_executable and
add_test.

Andreas

-- 
Snow Day -- stay home.