kde4_add_test is not sufficient

[Andreas Pakulat]

On 05.06.07 22:46:02, Alexander Neundorf wrote:
> On Tuesday 05 June 2007 19:04, Andreas Pakulat wrote:
> > On 05.06.07 19:33:55, Thiago Macieira wrote:
> > > Andreas Pakulat wrote:
> > > >Hi,
> > > >
> > > >I'd like to know wether its expected that one needs both kde4_add_test
> > > >and add_test to make tests work even if KDE4_BUILD_TESTS was set to off?
> > > >
> > > >If one doesn't tell cmake via add_test() that a testcase exists the make
> > > >test target doesn't find any tests, even after building them via make
> > > ><testname>. I think add_test should be included in kde4_add_test, or is
> > > >there a reason why this is not done?
> > >
> > > Because I forgot about it when I wrote the macro, most likely.
> >
> > So that means add_test can just be added to kde4_add_test? Does this
> > need to wait for monday? (If not I'll do it right away, to not forget it
> > again).
> 
> Please wait with this.
> If you add it in kdelibs, then updating kdelibs but not updating another 
> module will lead to duplicated ADD_TEST() calls.
> The other way round, if you remove the then unnecessary ADD_TEST() calls in 
> the other modules, they will have no ADD_TEST() at all.
> 
> So please wait with this until monday.

Sure, no problem. Also do you say that I should port all modules when
I've done that? If so I need some help with that.

Andreas

-- 
Your lucky number has been disconnected.