ZLIB not being checked

David Faure faure at kde.org
Wed Feb 15 19:51:06 CET 2006


On Wednesday 15 February 2006 15:21, Paulo Jorge Guedes wrote:
> Well, the patch goes attached.
> Of ok I can commit.
> 
> Paulo
> 
> > -----Original Message-----
> > From: Paulo Jorge Guedes
> > Sent: quarta-feira, 15 de Fevereiro de 2006 13:55
> > To: 'kde-buildsystem at kde.org'
> > Subject: ZLIB not being checked
> > 
> > Hi,
> > 
> > kgzipfilter.cpp is not compiled if zlib is not found.
> > This causes a linkage error because the pieces of code that use gzip
> are
> > not surrounded by some macro like bzip2 for example (#ifdef
> > HAVE_BZIP2_SUPPORT).
> > I can see that there is already a "HAVE_LIBZ" being set, although the
> code
> > doesn't use it.
> > If you are interested in such a patch please let me know.

Hmm. I'm not sure gzip support should be optional. Without it you have
no ZIP support, and without ZIP support you have no KOffice, for instance.

[Doesn't Qt come with zlib anyway? (not sure if that one is useable by kdelibs though)]

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).


More information about the Kde-buildsystem mailing list