msvc patches for khtml/kjs

[Peter Kümmel]

Alexander Neundorf wrote:
> On Tuesday 07 February 2006 19:10, Peter Kümmel wrote:
>> With this patches khtml and kjs also compiles with msvc.
>> Any objections?
> 
> Without understanding the code or being responsible for it, just some minor 
> nitpicking:
> 

Should I try to explain? :)

> static inline KJS::JSObject *Object(KJS::ExecState *exec, const 
> KJS::Identifier &propertyName)
> 
> please start function names with lower case, that's the style used in Qt and I 
> think also everywhere in KDE:
> 
> KJS::JSObject *object(...)
> or 
> KJS::JSObject *getObject(...)
> (it seems a lot of functions in kjs/ use the getSomething() naming style).
> 
> Bye
> Alex

no problem, this is only because the original naming:

cacheGlobalObject

Peter