msvc patches for khtml/kjs

Alexander Neundorf neundorf at kde.org
Tue Feb 7 19:30:05 CET 2006


On Tuesday 07 February 2006 19:10, Peter Kümmel wrote:
> With this patches khtml and kjs also compiles with msvc.
> Any objections?

Without understanding the code or being responsible for it, just some minor 
nitpicking:

static inline KJS::JSObject *Object(KJS::ExecState *exec, const 
KJS::Identifier &propertyName)

please start function names with lower case, that's the style used in Qt and I 
think also everywhere in KDE:

KJS::JSObject *object(...)
or 
KJS::JSObject *getObject(...)
(it seems a lot of functions in kjs/ use the getSomething() naming style).

Bye
Alex
-- 
Work: alexander.neundorf AT jenoptik.com - http://www.jenoptik-los.de
Home: neundorf AT kde.org                - http://www.kde.org
      alex AT neundorf.net               - http://www.neundorf.net


More information about the Kde-buildsystem mailing list