KDE/kdegraphics/kfile-plugins

[Alexander Neundorf]

On Monday 17 April 2006 18:04, David Faure wrote:
> On Mon, Apr 17, 2006 at 02:39:02PM +0200, Laurent Montel wrote:
> > On Monday 17 April 2006 14:35, David Faure wrote:
> > > On Fri, Apr 14, 2006 at 12:14:16PM +0000, Laurent Montel wrote:
> > > > SVN commit 529768 by mlaurent:
> > > >
> > > > Fix cmake variable
> > > >
> > > >
> > > >  M  +1 -1      exr/CMakeLists.txt
> > > >  M  +1 -1      jpeg/CMakeLists.txt
> > > >  M  +1 -1      png/CMakeLists.txt
> > > >  M  +1 -1      ps/CMakeLists.txt
> > > >  M  +1 -1      raw/CMakeLists.txt
> > > >  M  +1 -1      tiff/CMakeLists.txt
> > > >  M  +1 -1      xpm/CMakeLists.txt
> > > >
> > > >
> > > > --- trunk/KDE/kdegraphics/kfile-plugins/exr/CMakeLists.txt
> > > > #529767:529768 @@ -14,7 +14,7 @@
> > > >
> > > >  kde4_install_libtool_file( ${PLUGIN_INSTALL_DIR} kfile_exr )
> > > >
> > > > -target_link_libraries(kfile_exr  ${KDE4_KIO_LIBRARIES}
> > > > ${OPENEXR_LIBRARIES} ) +target_link_libraries(kfile_exr 
> > > > ${KDE4_KIO_LIBS} ${OPENEXR_LIBRARIES} )
> > >
> > > Hmm, really? I thought it was KDE4_KIO_LIBRARIES ?
> >
> > No KDE4_KIO_LIBRARIES is just -lkio
> > but # KDE4_KIO_LIBS              - the kio library and all depending
> > libraries
> >
> > So for building it we must add all dependancy
>
> This is very surprising. I thought the usual way in cmake was like
> KDE4_KIO_LIBRARY  (just kio)
> KDE4_KIO_LIBRARIES (kio and dependent libs)
>
> This is what was done for X11, Qt, pcre, openssl, agg, akode ... i.e.
> everything else in kdelibs/cmake/modules. But indeed not for the kde libs.
> Hmm - what does kde-buildsystem think?

I intentionally changed the naming from KDE4_FOO_LIBRARIES to KDE4_FOO_LIBS to 
save some typing and to avoid complaints from KDE devs ("cmake is so verbose, 
how inconvenient, how much nicer was this with autotools")

So, changing the other cmake modules to "XXX_LIBS" is no option, but for the 
KDE libs we can do as we want to.
I don't really care whether we name them "_LIBS" or "_LIBRARIES" (with _LIBS 
being easier to type and already used in many places).

Bye
Alex
-- 
Work: alexander.neundorf AT jenoptik.com - http://www.jenoptik-los.de
Home: neundorf AT kde.org                - http://www.kde.org
      alex AT neundorf.net               - http://www.neundorf.net