KDE/kdegraphics/kfile-plugins

[Laurent Montel]

On Monday 17 April 2006 18:04, David Faure wrote:
> On Mon, Apr 17, 2006 at 02:39:02PM +0200, Laurent Montel wrote:
> > On Monday 17 April 2006 14:35, David Faure wrote:
> > > On Fri, Apr 14, 2006 at 12:14:16PM +0000, Laurent Montel wrote:
> > > > SVN commit 529768 by mlaurent:
> > > >
> > > > Fix cmake variable
> > > >
> > > >
> > > >  M  +1 -1      exr/CMakeLists.txt
> > > >  M  +1 -1      jpeg/CMakeLists.txt
> > > >  M  +1 -1      png/CMakeLists.txt
> > > >  M  +1 -1      ps/CMakeLists.txt
> > > >  M  +1 -1      raw/CMakeLists.txt
> > > >  M  +1 -1      tiff/CMakeLists.txt
> > > >  M  +1 -1      xpm/CMakeLists.txt
> > > >
> > > >
> > > > --- trunk/KDE/kdegraphics/kfile-plugins/exr/CMakeLists.txt
> > > > #529767:529768 @@ -14,7 +14,7 @@
> > > >
> > > >  kde4_install_libtool_file( ${PLUGIN_INSTALL_DIR} kfile_exr )
> > > >
> > > > -target_link_libraries(kfile_exr  ${KDE4_KIO_LIBRARIES}
> > > > ${OPENEXR_LIBRARIES} ) +target_link_libraries(kfile_exr 
> > > > ${KDE4_KIO_LIBS} ${OPENEXR_LIBRARIES} )
> > >
> > > Hmm, really? I thought it was KDE4_KIO_LIBRARIES ?
> >
> > No KDE4_KIO_LIBRARIES is just -lkio
> > but # KDE4_KIO_LIBS              - the kio library and all depending
> > libraries
> >
> > So for building it we must add all dependancy
>
> This is very surprising. I thought the usual way in cmake was like
> KDE4_KIO_LIBRARY  (just kio)
> KDE4_KIO_LIBRARIES (kio and dependent libs)
>
> This is what was done for X11, Qt, pcre, openssl, agg, akode ... i.e.
> everything else in kdelibs/cmake/modules. But indeed not for the kde libs.
> Hmm - what does kde-buildsystem think?

For me it will more consistant to change it as for other cmake modules.