make -j4 broken again?

[William A. Hoffman]

At 02:47 PM 4/4/2006, David Faure wrote:
>On Tuesday 04 April 2006 20:40, William A. Hoffman wrote:
>> I think the parallel build is broken again.
>> 
>> There are random failures on this dashboard:
>> http://public.kitware.com/KDE/Testing/Sites/matt.rogers.name/Linux-Archlinux-gcc4.0.3/20060404-0100-Nightly/BuildError.html
>> 
>> It uses make -j4 for the build.  The other dashboard on dash17 is working fine for
>> the same build, and it does not use parallel builds.
>
>Right; this looks like a missing dependency on settings.h, which is a generated header file
>(generated from settings.kcfgc using kconfig_compiler.
>
>So this would be a bug in KDE4_ADD_KCFG_FILES, from kdelibs/cmake/modules/KDE4Macros.cmake
>Hmm. Would this fix it?
>--- KDE4Macros.cmake    (revision 526070)
>+++ KDE4Macros.cmake    (working copy)
>@@ -128,6 +128,7 @@ MACRO (KDE4_ADD_KCFG_FILES _sources)
>       SET_SOURCE_FILES_PROPERTIES(${_header_FILE} PROPERTIES GENERATED TRUE)
>       QT4_GENERATE_MOC(${_header_FILE} ${_moc_FILE} )
>       MACRO_ADD_FILE_DEPENDENCIES(${_src_FILE} ${_moc_FILE} )
>+      MACRO_ADD_FILE_DEPENDENCIES(${_moc_FILE} ${_header_FILE} )
>
>       set(${_sources} ${${_sources}} ${_src_FILE})
All generated header files now need to be part of the sources for the target 
they are part of.   

So, maybe this would fix it:

set(${_sources} ${${_sources}} ${_src_FILE} ${_header_FILE})

-Bill