[Patch] fix compile kdeui with msvc
Ralf Habacker
ralf.habacker at freenet.de
Mon Oct 31 16:05:27 CET 2005
Am Montag, 31. Oktober 2005 15:47 schrieb David Faure:
> On Monday 31 October 2005 15:27, Ralf Habacker wrote:
> > Append is a patch for this, does anyhave see any problem ?
>
> CFLAGS missing?
CCFLAGS is the internal representation of known CFLAGS, the name comes from
'CC' env var. c++ flags are located in CXXFLAGS.
> > One question is if this should be activated by default ?
> >
> > Index: generic.py
> > ===================================================================
> > --- generic.py (revision 476063)
> > +++ generic.py (working copy)
> > @@ -285,6 +285,9 @@
> > if self.libprefix != '' and
> > self.target[:len(self.libprefix)] == self.libprefix:
> > self.target = self.target[len(self.libprefix):]
> >
> > + if self.type in ['shlib','kioslave','module']:
> > + self.env.AppendUnique( CCFLAGS =
> > ['-DMAKE_'+self.target.upper()+'_LIB'] )
>
> Looks good to me. I see no reason against having this activated by default,
> it will be useful in all svn modules.
More information about the Kde-buildsystem
mailing list