[Patch] fix compile kdeui with msvc

David Faure faure at kde.org
Mon Oct 31 15:47:13 CET 2005


On Monday 31 October 2005 15:27, Ralf Habacker wrote:
> Append is a patch for this, does anyhave see any problem  ? 

CFLAGS missing?

> One question is if this should be activated by default ? 
> 
> Index: generic.py
> ===================================================================
> --- generic.py  (revision 476063)
> +++ generic.py  (working copy)
> @@ -285,6 +285,9 @@
>                 if self.libprefix != '' and self.target[:len(self.libprefix)] 
> == self.libprefix:
>                         self.target = self.target[len(self.libprefix):]
> 
> +               if self.type in ['shlib','kioslave','module']:
> +                       self.env.AppendUnique( CCFLAGS = 
> ['-DMAKE_'+self.target.upper()+'_LIB'] )

Looks good to me. I see no reason against having this activated by default, 
it will be useful in all svn modules.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).



More information about the Kde-buildsystem mailing list