[Kde-bindings] Re: Smokegen core dump

[Arno Rehn]

On Thursday 24 February 2011 15:22:03 Alberto Villa wrote:
> On Thursday 24 February 2011 15:00:21 Arno Rehn wrote:
> > Interesting. Thanks for the investigation. :) Seems like we found our
> > culprit.
> 
> great!
> 
> by the way, shouldn't this line (generator/parser/rpp/chartools.h)
> #define characterFromIndex(index) ((char)(index & 0xffff))
> be
> #define characterFromIndex(index) ((char)(index & 0xff))
> just in case some wrong index is passed to it? as far as i know the (char)
> cast should trim it correctly, but may it be that some weird
> architectures/compilers/environments don't do the right thing?
Could be. I don't really know that much about the C++ parser itself. We 
basically copied it over from KDevelop and removed all the KDE dependencies. 
I'll check the current KDevelop source and see what they do. Maybe our bug has 
already been fixed in their parser.

-- 
Arno Rehn
arno at arnorehn.de