[Kde-bindings] Re: Smokegen core dump

Alberto Villa avilla at freebsd.org
Thu Feb 24 14:22:03 UTC 2011


On Thursday 24 February 2011 15:00:21 Arno Rehn wrote:
> Interesting. Thanks for the investigation. :) Seems like we found our
> culprit.

great!

by the way, shouldn't this line (generator/parser/rpp/chartools.h)
#define characterFromIndex(index) ((char)(index & 0xffff))
be
#define characterFromIndex(index) ((char)(index & 0xff))
just in case some wrong index is passed to it? as far as i know the (char) 
cast should trim it correctly, but may it be that some weird 
architectures/compilers/environments don't do the right thing?
-- 
Alberto Villa, FreeBSD committer <avilla at FreeBSD.org>
http://people.FreeBSD.org/~avilla

The yankees, son, are up north.
The damnyankees are down here.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 314 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-bindings/attachments/20110224/ea81ddd2/attachment.sig>


More information about the Kde-bindings mailing list