[Kde-bindings] Patches for Qyoto on Windows (final)

[Steven Boswell II]

OK, I'll fix the references to LIB_INSTALL_DIR.  There were comments in the CMakeLists.txt files along the lines you mention, but they weren't applied consistently, so I wasn't sure what to do.  I'll go patch that up properly, and double-check my patches to qyoto with what's in assemblygen.

Someone needs to add a note to https://projects.kde.org/projects/kde/kdebindings/csharp/qyoto/ and https://projects.kde.org/projects/kde/kdebindings/csharp/kimono to mention that they're obsolete and to point to the new repo.

Steven Boswell



________________________________
 From: Arno Rehn <arno at arnorehn.de>
To: KDE bindings for other programming languages <kde-bindings at kde.org> 
Sent: Friday, December 9, 2011 2:45 AM
Subject: Re: [Kde-bindings] Patches for Qyoto on Windows (final)
 
On Thursday 08 December 2011 16:07:40 Steven Boswell II wrote:
> smokeqt:
> Put quotes around the reference to SMOKE_CMAKE_MODULE_DIR, so that spaces
> can appear in the installation path. Added ARCHIVE DESTINATION and RUNTIME
> DESTINATION to the install line of all the DLLs.  (No apparent effect under
> Linux.) Got rid of the "lib" prefix on Windows DLLs/archives.
Your patch uses ${LIB_INSTALL_DIR} in quite some places. However this macro is 
not defined at all for smokeqt (it's a KDE one and we want to keep smokeqt 
clean of KDE stuff). I don't know why this even works on Windows.
Anyway, in some places a seperate code path for non windows platforms is 
missing (phonon, qsci, ...), so on linux ${LIB_INSTALL_DIR} evaluates to "" 
and then it complains about a missing argument for LIBRARY DESTINATION.

-- 
Arno Rehn
_______________________________________________
Kde-bindings mailing list
Kde-bindings at kde.org
https://mail.kde.org/mailman/listinfo/kde-bindings
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-bindings/attachments/20111209/5b000b74/attachment.html>