[Kde-bindings] Patches for Qyoto on Windows (final)

Arno Rehn arno at arnorehn.de
Fri Dec 9 09:45:12 UTC 2011


On Thursday 08 December 2011 16:07:40 Steven Boswell II wrote:
> smokeqt:
> Put quotes around the reference to SMOKE_CMAKE_MODULE_DIR, so that spaces
> can appear in the installation path. Added ARCHIVE DESTINATION and RUNTIME
> DESTINATION to the install line of all the DLLs.  (No apparent effect under
> Linux.) Got rid of the "lib" prefix on Windows DLLs/archives.
Your patch uses ${LIB_INSTALL_DIR} in quite some places. However this macro is 
not defined at all for smokeqt (it's a KDE one and we want to keep smokeqt 
clean of KDE stuff). I don't know why this even works on Windows.
Anyway, in some places a seperate code path for non windows platforms is 
missing (phonon, qsci, ...), so on linux ${LIB_INSTALL_DIR} evaluates to "" 
and then it complains about a missing argument for LIBRARY DESTINATION.

-- 
Arno Rehn


More information about the Kde-bindings mailing list